From 4c00bbc3ceaf9f77003ba381325d3f62a6dfb645 Mon Sep 17 00:00:00 2001
From: Tom Clift <tom.clift@papercut.com>
Date: Thu, 3 Sep 2020 22:06:31 +1000
Subject: [PATCH] feat: option to show empty rings

---
 common/config.js                 |  1 +
 js/components/QuadrantSection.js | 13 ++++++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/common/config.js b/common/config.js
index 0d7d556..a39ea95 100644
--- a/common/config.js
+++ b/common/config.js
@@ -31,6 +31,7 @@ export const rings = [
   'assess',
   'hold'
 ];
+export const showEmptyRings = false;
 
 const messages = {
   'languages-and-frameworks': 'Languages & Frameworks',
diff --git a/js/components/QuadrantSection.js b/js/components/QuadrantSection.js
index e4fc8d4..94ac5ba 100644
--- a/js/components/QuadrantSection.js
+++ b/js/components/QuadrantSection.js
@@ -1,12 +1,12 @@
 import React from 'react';
-import { translate, rings } from '../../common/config';
+import { translate, rings, showEmptyRings } from '../../common/config';
 import Badge from './Badge';
 import Link from './Link';
 import ItemList from './ItemList';
 import Flag from './Flag';
 
 const renderList = (ringName, quadrantName, groups, big) => {
-  const itemsInRing = groups[quadrantName][ringName];
+  const itemsInRing = groups[quadrantName][ringName] || [];
 
   if (big === true) {
     return (
@@ -37,9 +37,12 @@ const renderList = (ringName, quadrantName, groups, big) => {
 
 const renderRing = (ringName, quadrantName, groups, big) => {
   if (
-    !groups[quadrantName] ||
-    !groups[quadrantName][ringName] ||
-    groups[quadrantName][ringName].length === 0
+    !showEmptyRings &&
+    (
+      !groups[quadrantName] ||
+      !groups[quadrantName][ringName] ||
+      groups[quadrantName][ringName].length === 0
+    )
   ) {
     return null;
   }