feat: option to show empty rings

This commit is contained in:
Tom Clift
2020-09-03 22:06:31 +10:00
parent e99859edcb
commit 4c00bbc3ce
2 changed files with 9 additions and 5 deletions

View File

@@ -31,6 +31,7 @@ export const rings = [
'assess', 'assess',
'hold' 'hold'
]; ];
export const showEmptyRings = false;
const messages = { const messages = {
'languages-and-frameworks': 'Languages & Frameworks', 'languages-and-frameworks': 'Languages & Frameworks',

View File

@@ -1,12 +1,12 @@
import React from 'react'; import React from 'react';
import { translate, rings } from '../../common/config'; import { translate, rings, showEmptyRings } from '../../common/config';
import Badge from './Badge'; import Badge from './Badge';
import Link from './Link'; import Link from './Link';
import ItemList from './ItemList'; import ItemList from './ItemList';
import Flag from './Flag'; import Flag from './Flag';
const renderList = (ringName, quadrantName, groups, big) => { const renderList = (ringName, quadrantName, groups, big) => {
const itemsInRing = groups[quadrantName][ringName]; const itemsInRing = groups[quadrantName][ringName] || [];
if (big === true) { if (big === true) {
return ( return (
@@ -37,9 +37,12 @@ const renderList = (ringName, quadrantName, groups, big) => {
const renderRing = (ringName, quadrantName, groups, big) => { const renderRing = (ringName, quadrantName, groups, big) => {
if ( if (
!groups[quadrantName] || !showEmptyRings &&
!groups[quadrantName][ringName] || (
groups[quadrantName][ringName].length === 0 !groups[quadrantName] ||
!groups[quadrantName][ringName] ||
groups[quadrantName][ringName].length === 0
)
) { ) {
return null; return null;
} }