From e93fc30016e4649ce9d2d227fda894134c76915a Mon Sep 17 00:00:00 2001
From: Florian Brandel <florian.brandel@aoe.com>
Date: Thu, 3 Sep 2020 17:39:59 +0200
Subject: [PATCH] Fix warnings

---
 src/components/PageItem/PageItem.tsx |  2 +-
 src/components/Search/Search.tsx     |  4 ++--
 src/config.ts                        |  2 +-
 src/styles/components/button.scss    | 15 +++++++++++++++
 4 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/src/components/PageItem/PageItem.tsx b/src/components/PageItem/PageItem.tsx
index d2228d9..485ba06 100644
--- a/src/components/PageItem/PageItem.tsx
+++ b/src/components/PageItem/PageItem.tsx
@@ -165,7 +165,7 @@ export default function PageItem({pageName, items, leaving, onLeave}: PageItemPr
             animationRunner.run();
             setStateLeaving(false)
         }
-    }, [stateLeaving, leaving])
+    }, [stateLeaving, leaving, animationsIn, animationsOut, onLeave])
 
     const getAnimationStates = (name: string) => {
         if (!animations) {
diff --git a/src/components/Search/Search.tsx b/src/components/Search/Search.tsx
index 414b181..d7ee579 100644
--- a/src/components/Search/Search.tsx
+++ b/src/components/Search/Search.tsx
@@ -48,9 +48,9 @@ function Search({ value, onChange, onClose, open = false, onSubmit = () => {} }:
         </button>
       </span>
       {closable && (
-        <a className={classNames('search__close', { 'is-open': open })} onClick={handleClose}>
+        <button className={classNames('search__close link-button', { 'is-open': open })} onClick={handleClose}>
           <span className='icon icon--close' />
-        </a>
+        </button>
       )}
     </form>
   );
diff --git a/src/config.ts b/src/config.ts
index 9020b50..b9e6e3a 100644
--- a/src/config.ts
+++ b/src/config.ts
@@ -1,4 +1,4 @@
-import { Item, Radar } from './model';
+import { Item } from './model';
 
 export const radarName = 'AOE Technology Radar';
 export const radarNameShort = 'Technology Radar';
diff --git a/src/styles/components/button.scss b/src/styles/components/button.scss
index 6b07e42..a869a97 100644
--- a/src/styles/components/button.scss
+++ b/src/styles/components/button.scss
@@ -15,3 +15,18 @@
     margin-top: -11px;
   }
 }
+
+.link-button {
+  background-color: transparent;
+  border: none;
+  cursor: pointer;
+  text-decoration: underline;
+  display: inline;
+  margin: 0;
+  padding: 0;
+}
+
+.link-button:hover,
+.link-button:focus {
+  text-decoration: none;
+}